Thank you. Yay. Thank you so much, Michelle. Before I invite you into my office for a couple of questions, I want to remind everyone that you can go on the Slido, S-L-I-D-O, with the code 2124, and put in your questions for Michelle, which will ask him, please step into my office, sir. Isn't this nice? It's like a little talk show. I feel very Oprah right now.
How are you doing? Good. Pretty good. Yeah. Thank you for that talk. That was very interesting. The first thing I want to talk to you about is teams. I think a lot of what you talked about applies a lot in the real world to people who work in teams. Also, sometimes open source people are teams. How in a team can you be as generous with others' code as you are with either your own or yourself? Like you said, it's not perfect. I think often you have to build a trust relationship, and that means that the more you know someone and the more you trust your starter, the more feedback you can leave. At Matter, we have the saying, like, feedback is a gift. And it truly is. But it only becomes a gift once you start to appreciate it. So, when you're reviewing code, and someone is either new to the team, or new to the Opsource project, the first thing you try to figure out is, like, what part of this code is actually risky, right, which would break the product. That's what you comment on first. Then, if it's there, not too much there, then you can go into the more nitty stuff, and how much of that you leave, I think, primarily depends on how long you have been working with this person. Sometimes, I'm like, okay, I have already ten comments on this PR, I leave it with this. I would have done even more things slightly different, but, hey, I can also bring it up another time, or keep just a mental note in the back of my head and come back later if it becomes an issue. So, not all feedback we have has to be expressed.
That's a great point, and actually relates to one of the questions we got through Slido, which is, Michel. As a software engineer, would you also read or modify code from other engineers, and do you have any learnings there besides writing your own tests and your own code? Yes, definitely. I think people should feel very free in the company in general to touch our code. You don't own code. It's not yours.
Comments